Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #364

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Update README.md #364

merged 2 commits into from
Jul 29, 2024

Conversation

gomes89
Copy link
Contributor

@gomes89 gomes89 commented Jul 18, 2024

The Python example in the README doesn't consider extras in requirements.txt (see PEP 508). They need to be removed for correct processing.

Fix Python example to handle extras in requirements.txt
@waynebeaton
Copy link
Collaborator

I'm thinking that we should add a comment to indicate that this is a total hack and not intended to be a robust solution.

Add note clarifying one Python example should be avoided
@gomes89
Copy link
Contributor Author

gomes89 commented Jul 19, 2024

I added a note in the README to clarify it should be avoided.

@waynebeaton waynebeaton merged commit bec9ec9 into eclipse-dash:master Jul 29, 2024
5 checks passed
@gomes89 gomes89 deleted the fix-readme-python branch July 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants